8e9db11165
This is a very simple fix to a rather complicated issue. Essentially, hold-taps will "release" (raise) their captured keys before actually telling the event manager they have captured a key. This means the event manager ends up assigning the `last_listener_index` to the hold-tap subscription rather than the combo. So when the combo calls `ZMK_EVENT_RELEASE` it raises after the hold-tap instead of after the combo as the combo code expects. The corresponding test (which fails without this change) has also been added.
40 lines
596 B
Text
40 lines
596 B
Text
#include <dt-bindings/zmk/keys.h>
|
|
#include <behaviors.dtsi>
|
|
#include <dt-bindings/zmk/kscan-mock.h>
|
|
|
|
&mt {
|
|
flavor = "hold-preferred";
|
|
};
|
|
|
|
/ {
|
|
combos {
|
|
compatible = "zmk,combos";
|
|
combo_one {
|
|
timeout-ms = <40>;
|
|
key-positions = <0 1>;
|
|
bindings = <&kp X>;
|
|
};
|
|
};
|
|
|
|
keymap {
|
|
compatible = "zmk,keymap";
|
|
label = "Default keymap";
|
|
|
|
default_layer {
|
|
bindings = <
|
|
&kp A &kp B
|
|
&mt RSHFT RET &kp C
|
|
>;
|
|
};
|
|
};
|
|
};
|
|
|
|
&kscan {
|
|
events = <
|
|
ZMK_MOCK_PRESS(1,0,10)
|
|
ZMK_MOCK_PRESS(0,1,10)
|
|
ZMK_MOCK_PRESS(1,1,10)
|
|
ZMK_MOCK_RELEASE(0,1,50)
|
|
ZMK_MOCK_RELEASE(1,1,50)
|
|
>;
|
|
};
|