kb01/zmk
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Functional but janky impl of global quick tap.

Browse source
This commit is contained in:
Andrew Rae 2022-03-22 20:38:14 -04:00
parent 35e73d40f5
commit ff0b1149ea
1 changed files with 11 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
app/src/behaviors/behavior_hold_tap.c
View file

@ -91,19 +91,19 @@ const zmk_event_t *captured_events[ZMK_BHV_HOLD_TAP_MAX_CAPTURED_EVENTS] = {};
// Keep track of which key was tapped most recently for 'quick_tap_ms' // Keep track of which key was tapped most recently for 'quick_tap_ms'
struct last_tapped { struct last_tapped {
int32_t position; int32_t position;
int64_t tap_deadline; int64_t timestamp;
}; };
struct last_tapped last_tapped; struct last_tapped last_tapped;
static void store_last_tapped(struct active_hold_tap *hold_tap) { static void store_last_tapped(int32_t position, int64_t timestamp) {
last_tapped.position = hold_tap->position; last_tapped.position = position;
last_tapped.tap_deadline = hold_tap->timestamp + hold_tap->config->quick_tap_ms; last_tapped.timestamp = timestamp;
} }
static bool is_quick_tap(struct active_hold_tap *hold_tap) { static bool is_quick_tap(struct active_hold_tap *hold_tap) {
return last_tapped.position == hold_tap->position && return //last_tapped.position == hold_tap->position &&
last_tapped.tap_deadline > hold_tap->timestamp; last_tapped.timestamp + hold_tap->config->quick_tap_ms > hold_tap->timestamp;
} }
static int capture_event(const zmk_event_t *event) { static int capture_event(const zmk_event_t *event) {
@ -362,7 +362,7 @@ static int press_binding(struct active_hold_tap *hold_tap) {
} else { } else {
binding.behavior_dev = hold_tap->config->tap_behavior_dev; binding.behavior_dev = hold_tap->config->tap_behavior_dev;
binding.param1 = hold_tap->param_tap; binding.param1 = hold_tap->param_tap;
store_last_tapped(hold_tap); /* store_last_tapped(hold_tap); */
} }
return behavior_keymap_binding_pressed(&binding, event); return behavior_keymap_binding_pressed(&binding, event);
} }
@ -619,6 +619,10 @@ static int keycode_state_changed_listener(const zmk_event_t *eh) {
// we want to catch layer-up events too... how? // we want to catch layer-up events too... how?
struct zmk_keycode_state_changed *ev = as_zmk_keycode_state_changed(eh); struct zmk_keycode_state_changed *ev = as_zmk_keycode_state_changed(eh);
if (ev->state && !is_mod(ev->usage_page, ev->keycode)) {
store_last_tapped(0, ev->timestamp);
}
if (undecided_hold_tap == NULL) { if (undecided_hold_tap == NULL) {
// LOG_DBG("0x%02X bubble (no undecided hold_tap active)", ev->keycode); // LOG_DBG("0x%02X bubble (no undecided hold_tap active)", ev->keycode);
return ZMK_EV_EVENT_BUBBLE; return ZMK_EV_EVENT_BUBBLE;