kb01/zmk
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(hid): Eliminate data race in USB pathway causing dropped keys

Browse source
This commit is contained in:
Keeley Hoek 2024-04-11 17:27:18 -04:00
parent e22bc7620c
commit e697487d25
No known key found for this signature in database
GPG key ID: 32D31FC4BCD6D913
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/src/usb_hid.c
View file

@ -22,7 +22,7 @@ LOG_MODULE_DECLARE(zmk, CONFIG_ZMK_LOG_LEVEL);
static const struct device *hid_dev; static const struct device *hid_dev;
static K_SEM_DEFINE(hid_sem, 1, 1); static K_SEM_DEFINE(hid_sem, 0, 1);
static void in_ready_cb(const struct device *dev) { k_sem_give(&hid_sem); } static void in_ready_cb(const struct device *dev) { k_sem_give(&hid_sem); }
@ -136,11 +136,9 @@ static int zmk_usb_hid_send_report(const uint8_t *report, size_t len) {
case USB_DC_UNKNOWN: case USB_DC_UNKNOWN:
return -ENODEV; return -ENODEV;
default: default:
k_sem_take(&hid_sem, K_MSEC(30));
int err = hid_int_ep_write(hid_dev, report, len, NULL); int err = hid_int_ep_write(hid_dev, report, len, NULL);
if (!err) {
if (err) { k_sem_take(&hid_sem, K_MSEC(30));
k_sem_give(&hid_sem);
} }
return err; return err;