kb01/zmk
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

refactor(underglow): turn underglow off in low priority work queue

Browse source
This commit is contained in:
Xudong Zheng 2023-07-17 17:32:14 -04:00 • committed by Pete Johanson
parent 9a963abfc8
commit cb9c573b53
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
app/src/rgb_underglow.c
View file

@ -197,14 +197,14 @@ static void zmk_rgb_underglow_tick(struct k_work *work) {
} }
} }
K_WORK_DEFINE(underglow_work, zmk_rgb_underglow_tick); K_WORK_DEFINE(underglow_tick_work, zmk_rgb_underglow_tick);
static void zmk_rgb_underglow_tick_handler(struct k_timer *timer) { static void zmk_rgb_underglow_tick_handler(struct k_timer *timer) {
if (!state.on) { if (!state.on) {
return; return;
} }
k_work_submit_to_queue(zmk_workqueue_lowprio_work_q(), &underglow_work); k_work_submit_to_queue(zmk_workqueue_lowprio_work_q(), &underglow_tick_work);
} }
K_TIMER_DEFINE(underglow_tick, zmk_rgb_underglow_tick_handler, NULL); K_TIMER_DEFINE(underglow_tick, zmk_rgb_underglow_tick_handler, NULL);
@ -323,6 +323,16 @@ int zmk_rgb_underglow_on() {
return zmk_rgb_underglow_save_state(); return zmk_rgb_underglow_save_state();
} }
static void zmk_rgb_underglow_off_handler(struct k_work *work) {
for (int i = 0; i < STRIP_NUM_PIXELS; i++) {
pixels[i] = (struct led_rgb){r : 0, g : 0, b : 0};
}
led_strip_update_rgb(led_strip, pixels, STRIP_NUM_PIXELS);
}
K_WORK_DEFINE(underglow_off_work, zmk_rgb_underglow_off_handler);
int zmk_rgb_underglow_off() { int zmk_rgb_underglow_off() {
if (!led_strip) if (!led_strip)
return -ENODEV; return -ENODEV;
@ -336,11 +346,7 @@ int zmk_rgb_underglow_off() {
} }
#endif #endif
for (int i = 0; i < STRIP_NUM_PIXELS; i++) { k_work_submit_to_queue(zmk_workqueue_lowprio_work_q(), &underglow_off_work);
pixels[i] = (struct led_rgb){r : 0, g : 0, b : 0};
}
led_strip_update_rgb(led_strip, pixels, STRIP_NUM_PIXELS);
k_timer_stop(&underglow_tick); k_timer_stop(&underglow_tick);
state.on = false; state.on = false;