kb01/zmk
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

uncrustify

Browse source
This commit is contained in:
Okke Formsma 2020-08-31 22:39:32 +02:00
parent 95361f37ea
commit c2540cb999
1 changed files with 359 additions and 342 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

701
app/src/behaviors/behavior_tap_hold.c
View file

@ -23,385 +23,398 @@ LOG_MODULE_DECLARE(zmk, CONFIG_ZMK_LOG_LEVEL);
#if DT_NODE_EXISTS(DT_DRV_INST(0)) #if DT_NODE_EXISTS(DT_DRV_INST(0))
/************************************************************ DATA SETUP */ /************************************************************ DATA SETUP */
#define ZMK_BHV_TAP_HOLD_MAX_HELD 10 #define ZMK_BHV_TAP_HOLD_MAX_HELD 10
#define ZMK_BHV_TAP_HOLD_MAX_CAPTURED_EVENTS 40 #define ZMK_BHV_TAP_HOLD_MAX_CAPTURED_EVENTS 40
// increase if you have keyboard with more keys. // increase if you have keyboard with more keys.
#define ZMK_BHV_TAP_HOLD_POSITION_NOT_USED 9999 #define ZMK_BHV_TAP_HOLD_POSITION_NOT_USED 9999
struct behavior_tap_hold_behaviors { struct behavior_tap_hold_behaviors {
struct zmk_behavior_binding tap; struct zmk_behavior_binding tap;
struct zmk_behavior_binding hold; struct zmk_behavior_binding hold;
}; };
typedef k_timeout_t (*timer_func)(); typedef k_timeout_t (*timer_func)();
struct behavior_tap_hold_config { struct behavior_tap_hold_config {
timer_func tapping_term_ms; timer_func tapping_term_ms;
struct behavior_tap_hold_behaviors* behaviors; struct behavior_tap_hold_behaviors *behaviors;
char* flavor; char *flavor;
}; };
// this data is specific for each tap-hold // this data is specific for each tap-hold
struct active_tap_hold { struct active_tap_hold {
s32_t position; s32_t position;
bool is_decided; bool is_decided;
bool is_hold; bool is_hold;
const struct behavior_tap_hold_config *config; const struct behavior_tap_hold_config *config;
struct k_delayed_work work; struct k_delayed_work work;
bool work_is_cancelled; bool work_is_cancelled;
}; };
// The undecided tap hold is the tap hold that needs to be decided before // The undecided tap hold is the tap hold that needs to be decided before
// other keypress events can be released. While the undecided_tap chold is // other keypress events can be released. While the undecided_tap chold is
// not NULL, most events are captured in captured_events. // not NULL, most events are captured in captured_events.
// After the tap_hold is decided, it will stay in the active_tap_holds until // After the tap_hold is decided, it will stay in the active_tap_holds until
// its key-up has been processed and the delayed work is cleaned up. // its key-up has been processed and the delayed work is cleaned up.
struct active_tap_hold* undecided_tap_hold = NULL; struct active_tap_hold *undecided_tap_hold = NULL;
struct active_tap_hold active_tap_holds[ZMK_BHV_TAP_HOLD_MAX_HELD] = {}; struct active_tap_hold active_tap_holds[ZMK_BHV_TAP_HOLD_MAX_HELD] = {};
// We capture most position_state_changed events and some modifiers_state_changed events. // We capture most position_state_changed events and some modifiers_state_changed events.
const struct zmk_event_header* captured_events[ZMK_BHV_TAP_HOLD_MAX_CAPTURED_EVENTS] = {}; const struct zmk_event_header *captured_events[ZMK_BHV_TAP_HOLD_MAX_CAPTURED_EVENTS] = {};
/************************************************************ CAPTURED POSITION HELPER FUNCTIONS */ /************************************************************ CAPTURED POSITION HELPER FUNCTIONS */
static int capture_event(const struct zmk_event_header* event) { static int capture_event(const struct zmk_event_header *event)
for (int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_CAPTURED_EVENTS; i++) { {
if (captured_events[i] == NULL) { for (int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_CAPTURED_EVENTS; i++) {
captured_events[i] = event; if (captured_events[i] == NULL) {
return 0; captured_events[i] = event;
} return 0;
} }
return -ENOMEM; }
return -ENOMEM;
} }
static struct position_state_changed* find_captured_keydown_event(u32_t position){ static struct position_state_changed *find_captured_keydown_event(u32_t position)
struct position_state_changed *last_match = NULL; {
for (int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_CAPTURED_EVENTS; i++) { struct position_state_changed *last_match = NULL;
const struct zmk_event_header *eh = captured_events[i]; for (int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_CAPTURED_EVENTS; i++) {
if (eh == NULL) { const struct zmk_event_header *eh = captured_events[i];
return last_match; if (eh == NULL) {
} return last_match;
if (!is_position_state_changed(eh)) { }
continue; if (!is_position_state_changed(eh)) {
} continue;
struct position_state_changed* position_event = cast_position_state_changed(eh); }
if (position_event->position == position && position_event->state) { struct position_state_changed *position_event = cast_position_state_changed(eh);
last_match = position_event; if (position_event->position == position && position_event->state) {
} last_match = position_event;
} }
}
return last_match; return last_match;
} }
static void release_captured_events() { static void release_captured_events()
if (undecided_tap_hold != NULL) { {
return; if (undecided_tap_hold != NULL) {
} return;
}
// We use a trick to prevent copying the captured_events array. // We use a trick to prevent copying the captured_events array.
// //
// Events for different mod-tap instances are separated by a NULL pointer. // Events for different mod-tap instances are separated by a NULL pointer.
// //
// The first event popped will never be catched by the next active tap-hold // The first event popped will never be catched by the next active tap-hold
// because to start capturing a mod-tap-key-down event must first completely // because to start capturing a mod-tap-key-down event must first completely
// go through the events queue. // go through the events queue.
// //
// Example of this release process; // Example of this release process;
// [mt2_down, k1_down, k1_up, mt2_up, null, ...] // [mt2_down, k1_down, k1_up, mt2_up, null, ...]
// ^ // ^
// mt2_down position event isn't captured because no tap-hold is active. // mt2_down position event isn't captured because no tap-hold is active.
// mt2_down behavior event is handled, now we have an undecided tap-hold // mt2_down behavior event is handled, now we have an undecided tap-hold
// [null, k1_down, k1_up, mt2_up, null, ...] // [null, k1_down, k1_up, mt2_up, null, ...]
// ^ // ^
// k1_down is captured by the mt2 mod-tap // k1_down is captured by the mt2 mod-tap
// !note that searches for find_captured_keydown_event by the mt2 behavior will stop at the first null encountered // !note that searches for find_captured_keydown_event by the mt2 behavior will stop at the first null encountered
// [mt1_down, null, k1_up, mt2_up, null, ...] // [mt1_down, null, k1_up, mt2_up, null, ...]
// ^ // ^
// k1_up event is captured by the new tap-hold: // k1_up event is captured by the new tap-hold:
// [k1_down, k1_up, null, mt2_up, null, ...] // [k1_down, k1_up, null, mt2_up, null, ...]
// ^ // ^
// mt2_up event is not captured but causes release of mt2 behavior // mt2_up event is not captured but causes release of mt2 behavior
// [k1_down, k1_up, null, null, null, ...] // [k1_down, k1_up, null, null, null, ...]
// now mt2 will start releasing it's own captured positions. // now mt2 will start releasing it's own captured positions.
for(int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_CAPTURED_EVENTS; i++) { for (int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_CAPTURED_EVENTS; i++) {
const struct zmk_event_header* captured_event = captured_events[i]; const struct zmk_event_header *captured_event = captured_events[i];
if(captured_event == NULL) { if (captured_event == NULL) {
return; return;
} }
captured_events[i] = NULL; captured_events[i] = NULL;
if(undecided_tap_hold != NULL) { if (undecided_tap_hold != NULL) {
k_msleep(10); k_msleep(10);
} }
if(is_position_state_changed(captured_event)) { if (is_position_state_changed(captured_event)) {
struct position_state_changed *position_event = cast_position_state_changed(captured_event); struct position_state_changed *position_event = cast_position_state_changed(captured_event);
LOG_DBG("Releasing key position event for position %d %s", position_event->position, (position_event->state ? "pressed" : "released")); LOG_DBG("Releasing key position event for position %d %s", position_event->position, (position_event->state ? "pressed" : "released"));
} else { } else {
struct keycode_state_changed *modifier_event = cast_keycode_state_changed(captured_event); struct keycode_state_changed *modifier_event = cast_keycode_state_changed(captured_event);
LOG_DBG("Releasing mods changed event 0x%02X %s", modifier_event->keycode, (modifier_event->state ? "pressed" : "released")); LOG_DBG("Releasing mods changed event 0x%02X %s", modifier_event->keycode, (modifier_event->state ? "pressed" : "released"));
} }
ZMK_EVENT_RELEASE_AGAIN(captured_event); ZMK_EVENT_RELEASE_AGAIN(captured_event);
} }
} }
/************************************************************ ACTIVE TAP HOLD HELPER FUNCTIONS */ /************************************************************ ACTIVE TAP HOLD HELPER FUNCTIONS */
static struct active_tap_hold* find_tap_hold(u32_t position) { static struct active_tap_hold *find_tap_hold(u32_t position)
for (int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_HELD; i++) { {
if (active_tap_holds[i].position == position) { for (int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_HELD; i++) {
return &active_tap_holds[i]; if (active_tap_holds[i].position == position) {
} return &active_tap_holds[i];
} }
return NULL; }
return NULL;
} }
static struct active_tap_hold* store_tap_hold(u32_t position, const struct behavior_tap_hold_config* config) { static struct active_tap_hold *store_tap_hold(u32_t position, const struct behavior_tap_hold_config *config)
for (int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_HELD; i++) { {
if (active_tap_holds[i].position != ZMK_BHV_TAP_HOLD_POSITION_NOT_USED) { for (int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_HELD; i++) {
continue; if (active_tap_holds[i].position != ZMK_BHV_TAP_HOLD_POSITION_NOT_USED) {
} continue;
active_tap_holds[i].position = position; }
active_tap_holds[i].is_decided = false; active_tap_holds[i].position = position;
active_tap_holds[i].is_hold = false; active_tap_holds[i].is_decided = false;
active_tap_holds[i].config = config; active_tap_holds[i].is_hold = false;
return &active_tap_holds[i]; active_tap_holds[i].config = config;
} return &active_tap_holds[i];
return NULL; }
return NULL;
} }
static void clear_tap_hold(struct active_tap_hold * tap_hold) { static void clear_tap_hold(struct active_tap_hold *tap_hold)
tap_hold->position = ZMK_BHV_TAP_HOLD_POSITION_NOT_USED; {
tap_hold->is_decided = false; tap_hold->position = ZMK_BHV_TAP_HOLD_POSITION_NOT_USED;
tap_hold->is_hold = false; tap_hold->is_decided = false;
tap_hold->work_is_cancelled= false; tap_hold->is_hold = false;
tap_hold->work_is_cancelled = false;
} }
enum decision_moment{ enum decision_moment {
TH_KEY_UP = 0, TH_KEY_UP = 0,
TH_OTHER_KEY_DOWN = 1, TH_OTHER_KEY_DOWN = 1,
TH_OTHER_KEY_UP = 2, TH_OTHER_KEY_UP = 2,
TH_TIMER_EVENT = 3, TH_TIMER_EVENT = 3,
}; };
static void decide_balanced(struct active_tap_hold * tap_hold, enum decision_moment event) { static void decide_balanced(struct active_tap_hold *tap_hold, enum decision_moment event)
switch(event) {
case TH_KEY_UP:
tap_hold->is_hold = 0;
tap_hold->is_decided = true;
break;
case TH_OTHER_KEY_UP:
tap_hold->is_hold = 1;
tap_hold->is_decided = true;
break;
case TH_TIMER_EVENT:
tap_hold->is_hold = 1;
tap_hold->is_decided = true;
break;
default: return;
}
}
static void decide_tap_preferred(struct active_tap_hold * tap_hold, enum decision_moment event) {
switch(event) {
case TH_KEY_UP:
tap_hold->is_hold = 0;
tap_hold->is_decided = true;
break;
case TH_TIMER_EVENT:
tap_hold->is_hold = 1;
tap_hold->is_decided = true;
break;
default: return;
}
}
static void decide_hold_preferred(struct active_tap_hold * tap_hold, enum decision_moment event) {
switch(event) {
case TH_KEY_UP:
tap_hold->is_hold = 0;
tap_hold->is_decided = true;
break;
case TH_OTHER_KEY_DOWN:
tap_hold->is_hold = 1;
tap_hold->is_decided = true;
break;
case TH_TIMER_EVENT:
tap_hold->is_hold = 1;
tap_hold->is_decided = true;
break;
default: return;
}
}
static void decide_tap_hold(struct active_tap_hold * tap_hold, enum decision_moment event)
{ {
if (tap_hold->is_decided) { switch (event) {
return; case TH_KEY_UP:
} tap_hold->is_hold = 0;
tap_hold->is_decided = true;
if(tap_hold != undecided_tap_hold) { break;
LOG_DBG("ERROR found undecided tap hold that is not the active tap hold"); case TH_OTHER_KEY_UP:
return; tap_hold->is_hold = 1;
} tap_hold->is_decided = true;
break;
char* flavor = tap_hold->config->flavor; case TH_TIMER_EVENT:
if(strcmp(flavor, "balanced") == 0) { tap_hold->is_hold = 1;
decide_balanced(tap_hold, event); tap_hold->is_decided = true;
} else if(strcmp(flavor, "tap-preferred") == 0) { break;
decide_tap_preferred(tap_hold, event); default: return;
} else if(strcmp(flavor, "hold-preferred") == 0) { }
decide_hold_preferred(tap_hold, event);
}
if(!tap_hold->is_decided) {
return;
}
LOG_DBG("%d decided %s (%s event %d)", tap_hold->position, tap_hold->is_hold?"hold":"tap", flavor, event);
undecided_tap_hold = NULL;
struct zmk_behavior_binding *behavior;
if (tap_hold->is_hold) {
behavior = &tap_hold->config->behaviors->hold;
} else {
behavior = &tap_hold->config->behaviors->tap;
}
struct device *behavior_device = device_get_binding(behavior->behavior_dev);
behavior_keymap_binding_pressed(behavior_device, tap_hold->position, behavior->param1, behavior->param2);
release_captured_events();
} }
/************************************************************ tap_hold_binding and key handlers */ static void decide_tap_preferred(struct active_tap_hold *tap_hold, enum decision_moment event)
{
switch (event) {
case TH_KEY_UP:
tap_hold->is_hold = 0;
tap_hold->is_decided = true;
break;
case TH_TIMER_EVENT:
tap_hold->is_hold = 1;
tap_hold->is_decided = true;
break;
default: return;
}
}
static void decide_hold_preferred(struct active_tap_hold *tap_hold, enum decision_moment event)
{
switch (event) {
case TH_KEY_UP:
tap_hold->is_hold = 0;
tap_hold->is_decided = true;
break;
case TH_OTHER_KEY_DOWN:
tap_hold->is_hold = 1;
tap_hold->is_decided = true;
break;
case TH_TIMER_EVENT:
tap_hold->is_hold = 1;
tap_hold->is_decided = true;
break;
default: return;
}
}
static void decide_tap_hold(struct active_tap_hold *tap_hold, enum decision_moment event)
{
if (tap_hold->is_decided) {
return;
}
if (tap_hold != undecided_tap_hold) {
LOG_DBG("ERROR found undecided tap hold that is not the active tap hold");
return;
}
char *flavor = tap_hold->config->flavor;
if (strcmp(flavor, "balanced") == 0) {
decide_balanced(tap_hold, event);
} else if (strcmp(flavor, "tap-preferred") == 0) {
decide_tap_preferred(tap_hold, event);
} else if (strcmp(flavor, "hold-preferred") == 0) {
decide_hold_preferred(tap_hold, event);
}
if (!tap_hold->is_decided) {
return;
}
LOG_DBG("%d decided %s (%s event %d)", tap_hold->position, tap_hold->is_hold ? "hold" : "tap", flavor, event);
undecided_tap_hold = NULL;
struct zmk_behavior_binding *behavior;
if (tap_hold->is_hold) {
behavior = &tap_hold->config->behaviors->hold;
} else {
behavior = &tap_hold->config->behaviors->tap;
}
struct device *behavior_device = device_get_binding(behavior->behavior_dev);
behavior_keymap_binding_pressed(behavior_device, tap_hold->position, behavior->param1, behavior->param2);
release_captured_events();
}
/************************************************************ tap_hold_binding and key handlers */
static int on_tap_hold_binding_pressed(struct device *dev, u32_t position, u32_t _, u32_t __) static int on_tap_hold_binding_pressed(struct device *dev, u32_t position, u32_t _, u32_t __)
{ {
const struct behavior_tap_hold_config *cfg = dev->config_info; const struct behavior_tap_hold_config *cfg = dev->config_info;
if(undecided_tap_hold != NULL) { if (undecided_tap_hold != NULL) {
LOG_DBG("ERROR another tap-hold behavior is undecided."); LOG_DBG("ERROR another tap-hold behavior is undecided.");
// if this happens, make sure the behavior events occur AFTER other position events. // if this happens, make sure the behavior events occur AFTER other position events.
return 0; return 0;
} }
struct active_tap_hold *tap_hold = store_tap_hold(position, cfg); struct active_tap_hold *tap_hold = store_tap_hold(position, cfg);
if (tap_hold == NULL) { if (tap_hold == NULL) {
LOG_ERR("unable to store tap-hold info, did you press more than %d tap-holds?", ZMK_BHV_TAP_HOLD_MAX_HELD); LOG_ERR("unable to store tap-hold info, did you press more than %d tap-holds?", ZMK_BHV_TAP_HOLD_MAX_HELD);
return 0; return 0;
} }
LOG_DBG("%d new undecided tap_hold", position); LOG_DBG("%d new undecided tap_hold", position);
undecided_tap_hold = tap_hold; undecided_tap_hold = tap_hold;
k_delayed_work_submit(&tap_hold->work, cfg->tapping_term_ms()); k_delayed_work_submit(&tap_hold->work, cfg->tapping_term_ms());
//todo: once we get timing info for keypresses, start the timer relative to the original keypress // todo: once we get timing info for keypresses, start the timer relative to the original keypress
// don't forget to simulate a timer-event before the event after that time was handled. // don't forget to simulate a timer-event before the event after that time was handled.
return 0; return 0;
} }
static int on_tap_hold_binding_released(struct device *dev, u32_t position, u32_t _, u32_t __) static int on_tap_hold_binding_released(struct device *dev, u32_t position, u32_t _, u32_t __)
{ {
struct active_tap_hold *tap_hold = find_tap_hold(position); struct active_tap_hold *tap_hold = find_tap_hold(position);
if(tap_hold == NULL) {
LOG_ERR("ACTIVE_TAP_HOLD_CLEANED_UP_TOO_EARLY");
return 0;
}
int work_cancel_result = k_delayed_work_cancel(&tap_hold->work); if (tap_hold == NULL) {
decide_tap_hold(tap_hold, TH_KEY_UP); LOG_ERR("ACTIVE_TAP_HOLD_CLEANED_UP_TOO_EARLY");
return 0;
}
struct zmk_behavior_binding *behavior; int work_cancel_result = k_delayed_work_cancel(&tap_hold->work);
if (tap_hold->is_hold) { decide_tap_hold(tap_hold, TH_KEY_UP);
behavior = &tap_hold->config->behaviors->hold;
} else {
behavior = &tap_hold->config->behaviors->tap;
}
struct device *behavior_device = device_get_binding(behavior->behavior_dev); struct zmk_behavior_binding *behavior;
behavior_keymap_binding_released(behavior_device, tap_hold->position, behavior->param1, behavior->param2); if (tap_hold->is_hold) {
behavior = &tap_hold->config->behaviors->hold;
} else {
behavior = &tap_hold->config->behaviors->tap;
}
if(work_cancel_result == -EINPROGRESS) { struct device *behavior_device = device_get_binding(behavior->behavior_dev);
// let the timer handler clean up behavior_keymap_binding_released(behavior_device, tap_hold->position, behavior->param1, behavior->param2);
// if we'd clear now, the timer may call back for an uninitialized active_tap_hold.
LOG_DBG("%d tap-hold timer work in event queue", position);
tap_hold->work_is_cancelled = true;
} else {
LOG_DBG("%d cleaning up tap-hold", position);
clear_tap_hold(tap_hold);
}
return 0; if (work_cancel_result == -EINPROGRESS) {
// let the timer handler clean up
// if we'd clear now, the timer may call back for an uninitialized active_tap_hold.
LOG_DBG("%d tap-hold timer work in event queue", position);
tap_hold->work_is_cancelled = true;
} else {
LOG_DBG("%d cleaning up tap-hold", position);
clear_tap_hold(tap_hold);
}
return 0;
} }
static const struct behavior_driver_api behavior_tap_hold_driver_api = { static const struct behavior_driver_api behavior_tap_hold_driver_api = {
.binding_pressed = on_tap_hold_binding_pressed, .binding_pressed = on_tap_hold_binding_pressed,
.binding_released = on_tap_hold_binding_released, .binding_released = on_tap_hold_binding_released,
}; };
static int position_state_changed_listener(const struct zmk_event_header *eh) { static int position_state_changed_listener(const struct zmk_event_header *eh)
struct position_state_changed* ev = cast_position_state_changed(eh); {
struct position_state_changed *ev = cast_position_state_changed(eh);
if(undecided_tap_hold == NULL) { if (undecided_tap_hold == NULL) {
LOG_DBG("%d bubble (no undecided tap_hold active)", ev->position); LOG_DBG("%d bubble (no undecided tap_hold active)", ev->position);
return 0; return 0;
} }
if(undecided_tap_hold->position == ev->position) { if (undecided_tap_hold->position == ev->position) {
if(ev->state) { //keydown if (ev->state) { // keydown
LOG_ERR("tap-hold listener should be called before before most other listeners!"); LOG_ERR("tap-hold listener should be called before before most other listeners!");
return 0; return 0;
} else { //keyup } else { // keyup
LOG_DBG("%d bubble undecided tap-hold keyrelease event", undecided_tap_hold->position); LOG_DBG("%d bubble undecided tap-hold keyrelease event", undecided_tap_hold->position);
return 0; return 0;
} }
} }
if (!ev->state && find_captured_keydown_event(ev->position) == NULL) { if (!ev->state && find_captured_keydown_event(ev->position) == NULL) {
// no keydown event has been captured, let it bubble. // no keydown event has been captured, let it bubble.
// we'll catch modifiers later in modifier_state_changed_listener // we'll catch modifiers later in modifier_state_changed_listener
LOG_DBG("%d bubbling %d %s event", undecided_tap_hold->position, ev->position, ev->state?"down":"up"); LOG_DBG("%d bubbling %d %s event", undecided_tap_hold->position, ev->position, ev->state ? "down" : "up");
return 0; return 0;
} }
LOG_DBG("%d capturing %d %s event", undecided_tap_hold->position, ev->position, ev->state?"down":"up"); LOG_DBG("%d capturing %d %s event", undecided_tap_hold->position, ev->position, ev->state ? "down" : "up");
capture_event(eh); capture_event(eh);
decide_tap_hold(undecided_tap_hold, ev->state ? TH_OTHER_KEY_DOWN : TH_OTHER_KEY_UP); decide_tap_hold(undecided_tap_hold, ev->state ? TH_OTHER_KEY_DOWN : TH_OTHER_KEY_UP);
return ZMK_EV_EVENT_CAPTURED; return ZMK_EV_EVENT_CAPTURED;
} }
static bool is_mod(struct keycode_state_changed* ev) { static bool is_mod(struct keycode_state_changed *ev)
return ev->usage_page == USAGE_KEYPAD && ev->keycode >= LCTL && ev->keycode <= RGUI; {
return ev->usage_page == USAGE_KEYPAD && ev->keycode >= LCTL && ev->keycode <= RGUI;
} }
static int keycode_state_changed_listener(const struct zmk_event_header *eh) {
// we want to catch layer-up events too... how?
struct keycode_state_changed* ev = cast_keycode_state_changed(eh);
if(undecided_tap_hold == NULL) {
//LOG_DBG("0x%02X bubble (no undecided tap_hold active)", ev->keycode);
return 0;
}
if(!is_mod(ev)) { static int keycode_state_changed_listener(const struct zmk_event_header *eh)
//LOG_DBG("0x%02X bubble (not a mod)", ev->keycode); {
return 0; // we want to catch layer-up events too... how?
} struct keycode_state_changed *ev = cast_keycode_state_changed(eh);
// only key-up events will bubble through position_state_changed_listener if (undecided_tap_hold == NULL) {
// if a undecided_tap_hold is active. // LOG_DBG("0x%02X bubble (no undecided tap_hold active)", ev->keycode);
LOG_DBG("%d capturing 0x%02X %s event", undecided_tap_hold->position, ev->keycode, ev->state?"down":"up"); return 0;
capture_event(eh); }
return ZMK_EV_EVENT_CAPTURED;
if (!is_mod(ev)) {
// LOG_DBG("0x%02X bubble (not a mod)", ev->keycode);
return 0;
}
// only key-up events will bubble through position_state_changed_listener
// if a undecided_tap_hold is active.
LOG_DBG("%d capturing 0x%02X %s event", undecided_tap_hold->position, ev->keycode, ev->state ? "down" : "up");
capture_event(eh);
return ZMK_EV_EVENT_CAPTURED;
} }
int behavior_tap_hold_listener(const struct zmk_event_header *eh) { int behavior_tap_hold_listener(const struct zmk_event_header *eh)
if (is_position_state_changed(eh)) { {
return position_state_changed_listener(eh); if (is_position_state_changed(eh)) {
} else if (is_keycode_state_changed(eh)) { return position_state_changed_listener(eh);
return keycode_state_changed_listener(eh); } else if (is_keycode_state_changed(eh)) {
} return keycode_state_changed_listener(eh);
return 0; }
return 0;
} }
ZMK_LISTENER(behavior_tap_hold, behavior_tap_hold_listener); ZMK_LISTENER(behavior_tap_hold, behavior_tap_hold_listener);
@ -409,56 +422,60 @@ ZMK_SUBSCRIPTION(behavior_tap_hold, position_state_changed);
// this should be modifiers_state_changed, but unfrotunately that's not implemented yet. // this should be modifiers_state_changed, but unfrotunately that's not implemented yet.
ZMK_SUBSCRIPTION(behavior_tap_hold, keycode_state_changed); ZMK_SUBSCRIPTION(behavior_tap_hold, keycode_state_changed);
/************************************************************ TIMER FUNCTIONS */ /************************************************************ TIMER FUNCTIONS */
void behavior_tap_hold_timer_work_handler(struct k_work *item) void behavior_tap_hold_timer_work_handler(struct k_work *item)
{ {
struct active_tap_hold *tap_hold = CONTAINER_OF(item, struct active_tap_hold, work); struct active_tap_hold *tap_hold = CONTAINER_OF(item, struct active_tap_hold, work);
if(tap_hold->work_is_cancelled) {
clear_tap_hold(tap_hold); if (tap_hold->work_is_cancelled) {
} else { clear_tap_hold(tap_hold);
decide_tap_hold(tap_hold, TH_TIMER_EVENT); } else {
} decide_tap_hold(tap_hold, TH_TIMER_EVENT);
}
} }
static int behavior_tap_hold_init(struct device *dev) static int behavior_tap_hold_init(struct device *dev)
{ {
static bool init_first_run = true; static bool init_first_run = true;
if(init_first_run) {
for (int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_HELD; i++) { if (init_first_run) {
k_delayed_work_init(&active_tap_holds[i].work, behavior_tap_hold_timer_work_handler); for (int i = 0; i < ZMK_BHV_TAP_HOLD_MAX_HELD; i++) {
active_tap_holds[i].position = ZMK_BHV_TAP_HOLD_POSITION_NOT_USED; k_delayed_work_init(&active_tap_holds[i].work, behavior_tap_hold_timer_work_handler);
} active_tap_holds[i].position = ZMK_BHV_TAP_HOLD_POSITION_NOT_USED;
} }
init_first_run = false; }
return 0; init_first_run = false;
return 0;
} }
struct behavior_tap_hold_data {}; struct behavior_tap_hold_data {};
static struct behavior_tap_hold_data behavior_tap_hold_data; static struct behavior_tap_hold_data behavior_tap_hold_data;
/************************************************************ NODE CONFIG */ /************************************************************ NODE CONFIG */
#define _TRANSFORM_ENTRY(idx, node) \ #define _TRANSFORM_ENTRY(idx, node) \
{ .behavior_dev = DT_LABEL(DT_INST_PHANDLE_BY_IDX(node, bindings, idx)), \ { \
.param1 = COND_CODE_0(DT_INST_PHA_HAS_CELL_AT_IDX(node, bindings, idx, param1), (0), (DT_INST_PHA_BY_IDX(node, bindings, idx, param1))), \ .behavior_dev = DT_LABEL(DT_INST_PHANDLE_BY_IDX(node, bindings, idx)), \
.param2 = COND_CODE_0(DT_INST_PHA_HAS_CELL_AT_IDX(node, bindings, idx, param2), (0), (DT_INST_PHA_BY_IDX(node, bindings, idx, param2))), \ .param1 = COND_CODE_0(DT_INST_PHA_HAS_CELL_AT_IDX(node, bindings, idx, param1), (0), (DT_INST_PHA_BY_IDX(node, bindings, idx, param1))), \
}, .param2 = COND_CODE_0(DT_INST_PHA_HAS_CELL_AT_IDX(node, bindings, idx, param2), (0), (DT_INST_PHA_BY_IDX(node, bindings, idx, param2))), \
},
#define KP_INST(n) \ #define KP_INST(n) \
static k_timeout_t behavior_tap_hold_config_##n##_gettime() { return K_MSEC(DT_INST_PROP(n, tapping_term_ms)); } \ static k_timeout_t behavior_tap_hold_config_##n##_gettime() { return K_MSEC(DT_INST_PROP(n, tapping_term_ms)); } \
static struct behavior_tap_hold_behaviors behavior_tap_hold_behaviors_##n = { \ static struct behavior_tap_hold_behaviors behavior_tap_hold_behaviors_##n = { \
.tap = _TRANSFORM_ENTRY(0, n) \ .tap = _TRANSFORM_ENTRY(0, n) \
.hold = _TRANSFORM_ENTRY(1, n) \ .hold = _TRANSFORM_ENTRY(1, n) \
}; \ }; \
static struct behavior_tap_hold_config behavior_tap_hold_config_##n = { \ static struct behavior_tap_hold_config behavior_tap_hold_config_##n = { \
.behaviors = &behavior_tap_hold_behaviors_##n, \ .behaviors = &behavior_tap_hold_behaviors_##n, \
.tapping_term_ms = &behavior_tap_hold_config_##n##_gettime, \ .tapping_term_ms = &behavior_tap_hold_config_##n##_gettime, \
.flavor = DT_INST_PROP(n, flavor), \ .flavor = DT_INST_PROP(n, flavor), \
}; \ }; \
DEVICE_AND_API_INIT(behavior_tap_hold_##n, DT_INST_LABEL(n), behavior_tap_hold_init, \ DEVICE_AND_API_INIT( \
&behavior_tap_hold_data, \ behavior_tap_hold_##n, DT_INST_LABEL(n), behavior_tap_hold_init, \
&behavior_tap_hold_config_##n, \ &behavior_tap_hold_data, \
APPLICATION, CONFIG_KERNEL_INIT_PRIORITY_DEFAULT, \ &behavior_tap_hold_config_##n, \
&behavior_tap_hold_driver_api); APPLICATION, CONFIG_KERNEL_INIT_PRIORITY_DEFAULT, \
&behavior_tap_hold_driver_api);
DT_INST_FOREACH_STATUS_OKAY(KP_INST) DT_INST_FOREACH_STATUS_OKAY(KP_INST)