kb01/zmk
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(ble): Disable Auto Sec Req again.

Browse source 
* Auto security request actually makes macOS worse, so disable it,
  and remove our early request in favor of using GATT enforcement
 to ensure connections are secured.
This commit is contained in:
Peter Johanson 2024-01-04 00:22:04 +00:00 • committed by Pete Johanson
parent 7d1c1ae8fd
commit bc7b4b56bd
2 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
app/Kconfig
View file

@ -144,7 +144,6 @@ if ZMK_BLE
config ZMK_BLE_EXPERIMENTAL_CONN config ZMK_BLE_EXPERIMENTAL_CONN
bool "Experimental BLE connection changes" bool "Experimental BLE connection changes"
imply BT_GATT_AUTO_SEC_REQ
help help
Enables a combination of settings that are planned to be default in future versions of ZMK Enables a combination of settings that are planned to be default in future versions of ZMK
to improve connection stability. This includes changes to timing on BLE pairing initation, to improve connection stability. This includes changes to timing on BLE pairing initation,

6
app/src/ble.c
View file

@ -460,12 +460,6 @@ static void connected(struct bt_conn *conn, uint8_t err) {
LOG_DBG("Connected %s", addr); LOG_DBG("Connected %s", addr);
#if !IS_ENABLED(CONFIG_BT_GATT_AUTO_SEC_REQ)
if (bt_conn_set_security(conn, BT_SECURITY_L2)) {
LOG_ERR("Failed to set security");
}
#endif // !IS_ENABLED(CONFIG_BT_GATT_AUTO_SEC_REQ)
update_advertising(); update_advertising();
if (is_conn_active_profile(conn)) { if (is_conn_active_profile(conn)) {