From ba79ccaea2ba12283afb5f55aba36fbc3cb95284 Mon Sep 17 00:00:00 2001 From: urob <978080+urob@users.noreply.github.com> Date: Sat, 11 Mar 2023 15:37:05 -0500 Subject: [PATCH] Simplify conditional --- app/src/behaviors/behavior_hold_tap.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/src/behaviors/behavior_hold_tap.c b/app/src/behaviors/behavior_hold_tap.c index 9ebc877f..a9e4d642 100644 --- a/app/src/behaviors/behavior_hold_tap.c +++ b/app/src/behaviors/behavior_hold_tap.c @@ -588,8 +588,9 @@ static int position_state_changed_listener(const zmk_event_t *eh) { } // Store the position of pressed key for positional hold-tap purposes. - if (((!undecided_hold_tap->config->hold_trigger_on_release && ev->state) // key pressed - || (undecided_hold_tap->config->hold_trigger_on_release && !ev->state)) // key released + if ((undecided_hold_tap->config->hold_trigger_on_release != + ev->state) // key has been pressed and hold_trigger_on_release is not set, or key + // has been released and hold_trigger_on_release is set && (undecided_hold_tap->position_of_first_other_key_pressed == -1) // no other key has been pressed yet ) {