From b97737aa1b5c051747a55fe8227d5671bd17629c Mon Sep 17 00:00:00 2001 From: Nick Conway Date: Mon, 27 Jun 2022 05:33:16 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Pete Johanson --- app/src/behaviors/behavior_sensor_rotate.c | 2 +- app/src/behaviors/behavior_sensor_rotate_var.c | 2 +- app/src/keymap.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/src/behaviors/behavior_sensor_rotate.c b/app/src/behaviors/behavior_sensor_rotate.c index 0ef2ab29..a090f7f6 100644 --- a/app/src/behaviors/behavior_sensor_rotate.c +++ b/app/src/behaviors/behavior_sensor_rotate.c @@ -36,7 +36,7 @@ static int on_sensor_binding_triggered(struct zmk_behavior_binding *binding, err = sensor_channel_get(sensor, SENSOR_CHAN_ROTATION, &value); - if (err) { + if (err < 0) { LOG_WRN("Failed to get sensor rotation value: %d", err); return err; } diff --git a/app/src/behaviors/behavior_sensor_rotate_var.c b/app/src/behaviors/behavior_sensor_rotate_var.c index 6978e0bc..e707119b 100644 --- a/app/src/behaviors/behavior_sensor_rotate_var.c +++ b/app/src/behaviors/behavior_sensor_rotate_var.c @@ -36,7 +36,7 @@ static int on_sensor_binding_triggered(struct zmk_behavior_binding *binding, err = sensor_channel_get(sensor, SENSOR_CHAN_ROTATION, &value); - if (err) { + if (err < 0) { LOG_WRN("Failed to get sensor rotation value: %d", err); return err; } diff --git a/app/src/keymap.c b/app/src/keymap.c index b0469909..04a74483 100644 --- a/app/src/keymap.c +++ b/app/src/keymap.c @@ -269,7 +269,7 @@ int zmk_keymap_sensor_triggered(uint8_t sensor_number, const struct device *sens continue; } - struct zmk_behavior_binding_event event = {.position = 0, .timestamp = timestamp}; + struct zmk_behavior_binding_event event = {.position = sensor_number, .timestamp = timestamp}; ret = behavior_sensor_keymap_binding_triggered(binding, sensor, event); if (ret > 0) {