kb01/zmk
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #2 from andrewjrae/keycode-pre-releasing

Browse source 
Keycode pre releasing to fix rolling of repeat key
This commit is contained in:
j-w-e 2023-08-14 22:19:57 +02:00 • committed by GitHub
commit ae07631899
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
8 changed files with 91 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
app/src/hid_listener.c
View file

@ -19,6 +19,20 @@ LOG_MODULE_DECLARE(zmk, CONFIG_ZMK_LOG_LEVEL);
static int hid_listener_keycode_pressed(const struct zmk_keycode_state_changed *ev) { static int hid_listener_keycode_pressed(const struct zmk_keycode_state_changed *ev) {
int err, explicit_mods_changed, implicit_mods_changed; int err, explicit_mods_changed, implicit_mods_changed;
if (zmk_hid_is_pressed(ZMK_HID_USAGE(ev->usage_page, ev->keycode))) {
LOG_DBG("unregistering usage_page 0x%02X keycode 0x%02X since it was already pressed",
ev->usage_page, ev->keycode);
err = zmk_hid_release(ZMK_HID_USAGE(ev->usage_page, ev->keycode));
if (err < 0) {
LOG_DBG("Unable to pre-release keycode (%d)", err);
return err;
}
err = zmk_endpoints_send_report(ev->usage_page);
if (err < 0) {
LOG_ERR("Failed to send key report for pre-releasing keycode (%d)", err);
}
}
LOG_DBG("usage_page 0x%02X keycode 0x%02X implicit_mods 0x%02X explicit_mods 0x%02X", LOG_DBG("usage_page 0x%02X keycode 0x%02X implicit_mods 0x%02X explicit_mods 0x%02X",
ev->usage_page, ev->keycode, ev->implicit_modifiers, ev->explicit_modifiers); ev->usage_page, ev->keycode, ev->implicit_modifiers, ev->explicit_modifiers);
err = zmk_hid_press(ZMK_HID_USAGE(ev->usage_page, ev->keycode)); err = zmk_hid_press(ZMK_HID_USAGE(ev->usage_page, ev->keycode));

2
app/tests/key-repeat/tap-when-rolling/events.patterns Normal file
View file

@ -0,0 +1,2 @@
s/.*hid_listener_keycode_//p
s/.*hid_implicit_modifiers_//p

9
app/tests/key-repeat/tap-when-rolling/keycode_events.snapshot Normal file
View file

@ -0,0 +1,9 @@
pressed: usage_page 0x07 keycode 0x04 implicit_mods 0x00 explicit_mods 0x00
press: Modifiers set to 0x00
pressed: unregistering usage_page 0x07 keycode 0x04 since it was already pressed
pressed: usage_page 0x07 keycode 0x04 implicit_mods 0x00 explicit_mods 0x00
press: Modifiers set to 0x00
released: usage_page 0x07 keycode 0x04 implicit_mods 0x00 explicit_mods 0x00
release: Modifiers set to 0x00
released: usage_page 0x07 keycode 0x04 implicit_mods 0x00 explicit_mods 0x00
release: Modifiers set to 0x00

13
app/tests/key-repeat/tap-when-rolling/native_posix.keymap Normal file
View file

@ -0,0 +1,13 @@
#include <dt-bindings/zmk/keys.h>
#include <behaviors.dtsi>
#include <dt-bindings/zmk/kscan_mock.h>
#include "../behavior_keymap.dtsi"
&kscan {
events = <
ZMK_MOCK_PRESS(0,1,10)
ZMK_MOCK_PRESS(0,0,10)
ZMK_MOCK_RELEASE(0,1,10)
ZMK_MOCK_RELEASE(0,0,10)
>;
};

13
app/tests/key-repeat/tap-when-rolling/native_posix_64.keymap Normal file
View file

@ -0,0 +1,13 @@
#include <dt-bindings/zmk/keys.h>
#include <behaviors.dtsi>
#include <dt-bindings/zmk/kscan_mock.h>
#include "../behavior_keymap.dtsi"
&kscan {
events = <
ZMK_MOCK_PRESS(0,1,9000)
ZMK_MOCK_PRESS(0,0,30)
ZMK_MOCK_RELEASE(0,1,30)
ZMK_MOCK_RELEASE(0,0,3000)
>;
};

4
app/tests/modifiers/implicit/kp-rolling-symbols-same-key/events.patterns Normal file
View file

@ -0,0 +1,4 @@
s/.*hid_listener_keycode_//p
s/.*hid_register_mod/reg/p
s/.*hid_unregister_mod/unreg/p
s/.*zmk_hid_.*Modifiers set to /mods: Modifiers set to /p

9
app/tests/modifiers/implicit/kp-rolling-symbols-same-key/keycode_events.snapshot Normal file
View file

@ -0,0 +1,9 @@
pressed: usage_page 0x07 keycode 0x2E implicit_mods 0x02 explicit_mods 0x00
mods: Modifiers set to 0x02
pressed: unregistering usage_page 0x07 keycode 0x2E since it was already pressed
pressed: usage_page 0x07 keycode 0x2E implicit_mods 0x00 explicit_mods 0x00
mods: Modifiers set to 0x00
released: usage_page 0x07 keycode 0x2E implicit_mods 0x02 explicit_mods 0x00
mods: Modifiers set to 0x00
released: usage_page 0x07 keycode 0x2E implicit_mods 0x00 explicit_mods 0x00
mods: Modifiers set to 0x00

27
app/tests/modifiers/implicit/kp-rolling-symbols-same-key/native_posix_64.keymap Normal file
View file

@ -0,0 +1,27 @@
#include <dt-bindings/zmk/keys.h>
#include <behaviors.dtsi>
#include <dt-bindings/zmk/kscan_mock.h>
&kscan {
events = <
ZMK_MOCK_PRESS(0,0,10)
ZMK_MOCK_PRESS(0,1,10)
ZMK_MOCK_RELEASE(0,0,10)
ZMK_MOCK_RELEASE(0,1,10)
>;
};
/ {
keymap {
compatible = "zmk,keymap";
label ="Default keymap";
default_layer {
bindings = <
&kp PLUS &kp EQUAL
&none &none
>;
};
};
};