From a0f5ec6a3f71f4203c9c87e4ee4542d81b7b36f9 Mon Sep 17 00:00:00 2001
From: Joel Spadin <joelspadin@gmail.com>
Date: Fri, 5 Apr 2024 21:45:54 -0500
Subject: [PATCH] fix: Fix compiler warnings

---
 app/src/display/widgets/layer_status.c  | 6 +++---
 app/src/display/widgets/output_status.c | 2 +-
 app/src/kscan_sideband_behaviors.c      | 1 -
 app/src/rgb_underglow.c                 | 4 +++-
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/app/src/display/widgets/layer_status.c b/app/src/display/widgets/layer_status.c
index 73c2268e..70e54ee4 100644
--- a/app/src/display/widgets/layer_status.c
+++ b/app/src/display/widgets/layer_status.c
@@ -24,13 +24,13 @@ struct layer_status_state {
 
 static void set_layer_symbol(lv_obj_t *label, struct layer_status_state state) {
     if (state.label == NULL) {
-        char text[7] = {};
+        char text[16] = {};
 
-        sprintf(text, LV_SYMBOL_KEYBOARD " %i", state.index);
+        snprintf(text, sizeof(text), LV_SYMBOL_KEYBOARD " %i", state.index);
 
         lv_label_set_text(label, text);
     } else {
-        char text[13] = {};
+        char text[16] = {};
 
         snprintf(text, sizeof(text), LV_SYMBOL_KEYBOARD " %s", state.label);
 
diff --git a/app/src/display/widgets/output_status.c b/app/src/display/widgets/output_status.c
index da29a95f..31ecca23 100644
--- a/app/src/display/widgets/output_status.c
+++ b/app/src/display/widgets/output_status.c
@@ -35,7 +35,7 @@ static struct output_status_state get_state(const zmk_event_t *_eh) {
 }
 
 static void set_status_symbol(lv_obj_t *label, struct output_status_state state) {
-    char text[10] = {};
+    char text[24] = {};
 
     switch (state.selected_endpoint.transport) {
     case ZMK_TRANSPORT_USB:
diff --git a/app/src/kscan_sideband_behaviors.c b/app/src/kscan_sideband_behaviors.c
index 7a9922af..0f5f3301 100644
--- a/app/src/kscan_sideband_behaviors.c
+++ b/app/src/kscan_sideband_behaviors.c
@@ -93,7 +93,6 @@ void ksbb_inner_kscan_callback(const struct device *dev, uint32_t row, uint32_t
 }
 
 static int ksbb_configure(const struct device *dev, kscan_callback_t callback) {
-    const struct ksbb_config *cfg = dev->config;
     struct ksbb_data *data = dev->data;
 
     data->callback = callback;
diff --git a/app/src/rgb_underglow.c b/app/src/rgb_underglow.c
index a7a9b4f0..8276e9be 100644
--- a/app/src/rgb_underglow.c
+++ b/app/src/rgb_underglow.c
@@ -82,7 +82,9 @@ static struct zmk_led_hsb hsb_scale_zero_max(struct zmk_led_hsb hsb) {
 }
 
 static struct led_rgb hsb_to_rgb(struct zmk_led_hsb hsb) {
-    float r, g, b;
+    float r = 0;
+    float g = 0;
+    float b = 0;
 
     uint8_t i = hsb.h / 60;
     float v = hsb.b / ((float)BRT_MAX);