kb01/zmk
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(macro): set the macro release states wait_ms

Browse source 
when we create a release trigger state for each press state
we miss setting the releases wait_ms field, resulting in
key releases all occuring instantaneously

this can result in lost key release commands
see issue #2356
This commit is contained in:
Eva Emmerich 2024-07-02 20:26:51 -05:00
parent 7c09eb217e
commit 9595896a84
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/src/behaviors/behavior_macro.c
View file

@ -117,6 +117,11 @@ static int behavior_macro_init(const struct device *dev) {
LOG_DBG("Precalculate initial release state:");
for (int i = 0; i < cfg->count; i++) {
if (handle_control_binding(&state->release_state, &cfg->bindings[i])) {
// each press state has a nested release state
// we partially set it up above, but need to explicitly fill in the states wait_ms
// because future callers expect it to already be present
state->release_state.wait_ms = cfg->default_wait_ms;
LOG_DBG("set precomputed release_state wait_ms: %d", state->release_state.wait_ms);
// Updated state used for initial state on release.
} else if (IS_PAUSE(cfg->bindings[i].behavior_dev)) {
state->release_state.start_index = i + 1;