From 5e2e1a9bad03ea30247e0b17ab8098a3c08c931c Mon Sep 17 00:00:00 2001
From: Peter Johanson <peter@peterjohanson.com>
Date: Mon, 19 Feb 2024 10:23:16 +0000
Subject: [PATCH] fix: Testing fixes for listener refactor.

---
 app/dts/behaviors.dtsi                           |  7 ++++++-
 app/dts/behaviors/mouse_key_press.dtsi           |  5 +++++
 app/dts/behaviors/mouse_keys.dtsi                |  9 +++++++++
 app/dts/behaviors/mouse_move.dtsi                |  6 ++++++
 app/dts/behaviors/mouse_scroll.dtsi              |  6 ++++++
 app/src/mouse/input_listener.c                   |  2 +-
 app/tests/mouse-keys/mkp/native_posix_64.keymap  |  1 +
 .../keycode_events.snapshot                      | 16 ++++++----------
 .../move_diagonal_scaling/native_posix_64.keymap |  1 +
 .../keycode_events.snapshot                      | 16 ++++++----------
 .../native_posix_64.keymap                       |  1 +
 .../keycode_events.snapshot                      | 16 ++++++----------
 .../move_diagonal_xy_swap/native_posix_64.keymap |  1 +
 .../move_diagonal/keycode_events.snapshot        | 16 ++++++----------
 .../move_diagonal/native_posix_64.keymap         |  1 +
 .../mouse-move/move_x/keycode_events.snapshot    | 16 ++++++++--------
 .../mouse-move/move_x/native_posix_64.keymap     |  1 +
 .../mouse-move/move_y/keycode_events.snapshot    | 16 ++++++++--------
 .../mouse-move/move_y/native_posix_64.keymap     |  1 +
 19 files changed, 80 insertions(+), 58 deletions(-)
 create mode 100644 app/dts/behaviors/mouse_keys.dtsi

diff --git a/app/dts/behaviors.dtsi b/app/dts/behaviors.dtsi
index 69160868..672eb3c2 100644
--- a/app/dts/behaviors.dtsi
+++ b/app/dts/behaviors.dtsi
@@ -1,3 +1,9 @@
+/*
+ * Copyright (c) 2024 The ZMK Contributors
+ *
+ * SPDX-License-Identifier: MIT
+ */
+
 #include <behaviors/key_press.dtsi>
 #include <behaviors/key_toggle.dtsi>
 #include <behaviors/transparent.dtsi>
@@ -19,7 +25,6 @@
 #include <behaviors/key_repeat.dtsi>
 #include <behaviors/backlight.dtsi>
 #include <behaviors/macros.dtsi>
-#include <behaviors/mouse_key_press.dtsi>
 #include <behaviors/soft_off.dtsi>
 #include <behaviors/studio_unlock.dtsi>
 #include <behaviors/mouse_move.dtsi>
diff --git a/app/dts/behaviors/mouse_key_press.dtsi b/app/dts/behaviors/mouse_key_press.dtsi
index 4fbc2eb4..9e6f9337 100644
--- a/app/dts/behaviors/mouse_key_press.dtsi
+++ b/app/dts/behaviors/mouse_key_press.dtsi
@@ -16,4 +16,9 @@
             #binding-cells = <1>;
         };
     };
+
+    mkp_input_listener {
+        compatible = "zmk,input-listener";
+        device = <&mkp>;
+    };
 };
diff --git a/app/dts/behaviors/mouse_keys.dtsi b/app/dts/behaviors/mouse_keys.dtsi
new file mode 100644
index 00000000..f9a99fed
--- /dev/null
+++ b/app/dts/behaviors/mouse_keys.dtsi
@@ -0,0 +1,9 @@
+/*
+ * Copyright (c) 2024 The ZMK Contributors
+ *
+ * SPDX-License-Identifier: MIT
+ */
+
+#include "mouse_key_press.dtsi"
+#include "mouse_move.dtsi"
+#include "mouse_scroll.dtsi"
\ No newline at end of file
diff --git a/app/dts/behaviors/mouse_move.dtsi b/app/dts/behaviors/mouse_move.dtsi
index c43455c3..47dc6cec 100644
--- a/app/dts/behaviors/mouse_move.dtsi
+++ b/app/dts/behaviors/mouse_move.dtsi
@@ -1,3 +1,9 @@
+/*
+ * Copyright (c) 2024 The ZMK Contributors
+ *
+ * SPDX-License-Identifier: MIT
+ */
+
 #include <zephyr/dt-bindings/input/input-event-codes.h>
 
 / {
diff --git a/app/dts/behaviors/mouse_scroll.dtsi b/app/dts/behaviors/mouse_scroll.dtsi
index 27b6aafe..e9d141f8 100644
--- a/app/dts/behaviors/mouse_scroll.dtsi
+++ b/app/dts/behaviors/mouse_scroll.dtsi
@@ -1,3 +1,9 @@
+/*
+ * Copyright (c) 2024 The ZMK Contributors
+ *
+ * SPDX-License-Identifier: MIT
+ */
+
 #include <zephyr/dt-bindings/input/input-event-codes.h>
 
 / {
diff --git a/app/src/mouse/input_listener.c b/app/src/mouse/input_listener.c
index a00455bc..0acc4349 100644
--- a/app/src/mouse/input_listener.c
+++ b/app/src/mouse/input_listener.c
@@ -154,7 +154,7 @@ static void input_handler(const struct input_listener_config *config,
 
         if (data->button_clear != 0) {
             for (int i = 0; i < ZMK_HID_MOUSE_NUM_BUTTONS; i++) {
-                if ((data->button_set & BIT(i)) != 0) {
+                if ((data->button_clear & BIT(i)) != 0) {
                     zmk_hid_mouse_button_release(i);
                 }
             }
diff --git a/app/tests/mouse-keys/mkp/native_posix_64.keymap b/app/tests/mouse-keys/mkp/native_posix_64.keymap
index 8e3071d4..8b955846 100644
--- a/app/tests/mouse-keys/mkp/native_posix_64.keymap
+++ b/app/tests/mouse-keys/mkp/native_posix_64.keymap
@@ -1,4 +1,5 @@
 #include <behaviors.dtsi>
+#include <behaviors/mouse_keys.dtsi>
 #include <dt-bindings/zmk/keys.h>
 #include <dt-bindings/zmk/kscan_mock.h>
 #include <dt-bindings/zmk/mouse.h>
diff --git a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_scaling/keycode_events.snapshot b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_scaling/keycode_events.snapshot
index 99fa1488..6b9fa770 100644
--- a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_scaling/keycode_events.snapshot
+++ b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_scaling/keycode_events.snapshot
@@ -1,22 +1,18 @@
-movement_update: Mouse movement updated to -1/0
+movement_set: Mouse movement set to -1/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -3/0
-movement_update: Mouse movement updated to -3/-3
+movement_set: Mouse movement set to -2/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -3/0
-movement_update: Mouse movement updated to -3/-3
+movement_set: Mouse movement set to -2/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -5/0
-movement_update: Mouse movement updated to -5/-3
+movement_set: Mouse movement set to -3/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -5/0
-movement_update: Mouse movement updated to -5/-5
+movement_set: Mouse movement set to -3/-3
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/-5
+movement_set: Mouse movement set to 0/-3
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
diff --git a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_scaling/native_posix_64.keymap b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_scaling/native_posix_64.keymap
index b1ddbc1d..6351799b 100644
--- a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_scaling/native_posix_64.keymap
+++ b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_scaling/native_posix_64.keymap
@@ -1,4 +1,5 @@
 #include <behaviors.dtsi>
+#include <behaviors/mouse_move.dtsi>
 #include <dt-bindings/zmk/keys.h>
 #include <dt-bindings/zmk/kscan_mock.h>
 #include <dt-bindings/zmk/mouse.h>
diff --git a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_invert/keycode_events.snapshot b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_invert/keycode_events.snapshot
index 94faacce..6b9fa770 100644
--- a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_invert/keycode_events.snapshot
+++ b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_invert/keycode_events.snapshot
@@ -1,22 +1,18 @@
-movement_update: Mouse movement updated to 1/0
+movement_set: Mouse movement set to -1/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 2/0
-movement_update: Mouse movement updated to 2/2
+movement_set: Mouse movement set to -2/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 2/0
-movement_update: Mouse movement updated to 2/2
+movement_set: Mouse movement set to -2/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 3/0
-movement_update: Mouse movement updated to 3/2
+movement_set: Mouse movement set to -3/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 3/0
-movement_update: Mouse movement updated to 3/3
+movement_set: Mouse movement set to -3/-3
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/3
+movement_set: Mouse movement set to 0/-3
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
diff --git a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_invert/native_posix_64.keymap b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_invert/native_posix_64.keymap
index 4767e0ac..3392dd0d 100644
--- a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_invert/native_posix_64.keymap
+++ b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_invert/native_posix_64.keymap
@@ -1,4 +1,5 @@
 #include <behaviors.dtsi>
+#include <behaviors/mouse_move.dtsi>
 #include <dt-bindings/zmk/keys.h>
 #include <dt-bindings/zmk/kscan_mock.h>
 #include <dt-bindings/zmk/mouse.h>
diff --git a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_swap/keycode_events.snapshot b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_swap/keycode_events.snapshot
index 5ca5300c..6b9fa770 100644
--- a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_swap/keycode_events.snapshot
+++ b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_swap/keycode_events.snapshot
@@ -1,22 +1,18 @@
-movement_update: Mouse movement updated to 0/-1
+movement_set: Mouse movement set to -1/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/-2
-movement_update: Mouse movement updated to -2/-2
+movement_set: Mouse movement set to -2/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/-2
-movement_update: Mouse movement updated to -2/-2
+movement_set: Mouse movement set to -2/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/-3
-movement_update: Mouse movement updated to -2/-3
+movement_set: Mouse movement set to -3/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/-3
-movement_update: Mouse movement updated to -3/-3
+movement_set: Mouse movement set to -3/-3
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -3/0
+movement_set: Mouse movement set to 0/-3
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
diff --git a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_swap/native_posix_64.keymap b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_swap/native_posix_64.keymap
index 15327023..d4cf5031 100644
--- a/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_swap/native_posix_64.keymap
+++ b/app/tests/mouse-keys/mouse-move/input-configs/move_diagonal_xy_swap/native_posix_64.keymap
@@ -1,4 +1,5 @@
 #include <behaviors.dtsi>
+#include <behaviors/mouse_move.dtsi>
 #include <dt-bindings/zmk/keys.h>
 #include <dt-bindings/zmk/kscan_mock.h>
 #include <dt-bindings/zmk/mouse.h>
diff --git a/app/tests/mouse-keys/mouse-move/move_diagonal/keycode_events.snapshot b/app/tests/mouse-keys/mouse-move/move_diagonal/keycode_events.snapshot
index 91c4f16b..6b9fa770 100644
--- a/app/tests/mouse-keys/mouse-move/move_diagonal/keycode_events.snapshot
+++ b/app/tests/mouse-keys/mouse-move/move_diagonal/keycode_events.snapshot
@@ -1,22 +1,18 @@
-movement_update: Mouse movement updated to -1/0
+movement_set: Mouse movement set to -1/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -2/0
-movement_update: Mouse movement updated to -2/-2
+movement_set: Mouse movement set to -2/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -2/0
-movement_update: Mouse movement updated to -2/-2
+movement_set: Mouse movement set to -2/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -3/0
-movement_update: Mouse movement updated to -3/-2
+movement_set: Mouse movement set to -3/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -3/0
-movement_update: Mouse movement updated to -3/-3
+movement_set: Mouse movement set to -3/-3
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/-3
+movement_set: Mouse movement set to 0/-3
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
diff --git a/app/tests/mouse-keys/mouse-move/move_diagonal/native_posix_64.keymap b/app/tests/mouse-keys/mouse-move/move_diagonal/native_posix_64.keymap
index 9dfa5b2a..7e4d7af2 100644
--- a/app/tests/mouse-keys/mouse-move/move_diagonal/native_posix_64.keymap
+++ b/app/tests/mouse-keys/mouse-move/move_diagonal/native_posix_64.keymap
@@ -1,4 +1,5 @@
 #include <behaviors.dtsi>
+#include <behaviors/mouse_move.dtsi>
 #include <dt-bindings/zmk/keys.h>
 #include <dt-bindings/zmk/kscan_mock.h>
 #include <dt-bindings/zmk/mouse.h>
diff --git a/app/tests/mouse-keys/mouse-move/move_x/keycode_events.snapshot b/app/tests/mouse-keys/mouse-move/move_x/keycode_events.snapshot
index dfbc4a76..678f71c9 100644
--- a/app/tests/mouse-keys/mouse-move/move_x/keycode_events.snapshot
+++ b/app/tests/mouse-keys/mouse-move/move_x/keycode_events.snapshot
@@ -1,24 +1,24 @@
-movement_update: Mouse movement updated to -1/0
+movement_set: Mouse movement set to -1/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -2/0
+movement_set: Mouse movement set to -2/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -2/0
+movement_set: Mouse movement set to -2/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to -3/0
+movement_set: Mouse movement set to -3/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 1/0
+movement_set: Mouse movement set to 1/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 2/0
+movement_set: Mouse movement set to 2/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 2/0
+movement_set: Mouse movement set to 2/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 3/0
+movement_set: Mouse movement set to 3/0
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
diff --git a/app/tests/mouse-keys/mouse-move/move_x/native_posix_64.keymap b/app/tests/mouse-keys/mouse-move/move_x/native_posix_64.keymap
index aacacebb..89d50e2b 100644
--- a/app/tests/mouse-keys/mouse-move/move_x/native_posix_64.keymap
+++ b/app/tests/mouse-keys/mouse-move/move_x/native_posix_64.keymap
@@ -1,4 +1,5 @@
 #include <behaviors.dtsi>
+#include <behaviors/mouse_move.dtsi>
 #include <dt-bindings/zmk/keys.h>
 #include <dt-bindings/zmk/kscan_mock.h>
 #include <dt-bindings/zmk/mouse.h>
diff --git a/app/tests/mouse-keys/mouse-move/move_y/keycode_events.snapshot b/app/tests/mouse-keys/mouse-move/move_y/keycode_events.snapshot
index 4fd9a252..d20154d5 100644
--- a/app/tests/mouse-keys/mouse-move/move_y/keycode_events.snapshot
+++ b/app/tests/mouse-keys/mouse-move/move_y/keycode_events.snapshot
@@ -1,24 +1,24 @@
-movement_update: Mouse movement updated to 0/-1
+movement_set: Mouse movement set to 0/-1
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/-2
+movement_set: Mouse movement set to 0/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/-2
+movement_set: Mouse movement set to 0/-2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/-3
+movement_set: Mouse movement set to 0/-3
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/1
+movement_set: Mouse movement set to 0/1
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/2
+movement_set: Mouse movement set to 0/2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/2
+movement_set: Mouse movement set to 0/2
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
-movement_update: Mouse movement updated to 0/3
+movement_set: Mouse movement set to 0/3
 scroll_set: Mouse scroll set to 0/0
 movement_set: Mouse movement set to 0/0
diff --git a/app/tests/mouse-keys/mouse-move/move_y/native_posix_64.keymap b/app/tests/mouse-keys/mouse-move/move_y/native_posix_64.keymap
index 1d914136..5b02246b 100644
--- a/app/tests/mouse-keys/mouse-move/move_y/native_posix_64.keymap
+++ b/app/tests/mouse-keys/mouse-move/move_y/native_posix_64.keymap
@@ -1,4 +1,5 @@
 #include <behaviors.dtsi>
+#include <behaviors/mouse_move.dtsi>
 #include <dt-bindings/zmk/keys.h>
 #include <dt-bindings/zmk/kscan_mock.h>
 #include <dt-bindings/zmk/mouse.h>