kb01/zmk
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Log errors for unsupported/invalid reports over USB

Browse source
This commit is contained in:
Ryan P. Bitanga 2022-02-21 20:11:39 +08:00
parent 606c18f257
commit 351749d2fd
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/usb.c
View file

@ -50,6 +50,7 @@ static int zmk_usb_get_report(const struct device *dev,
* For requested reports that aren't input reports, return -ENOTSUP like the Zephyr subsys does * For requested reports that aren't input reports, return -ENOTSUP like the Zephyr subsys does
*/ */
if ((setup->wValue & HID_GET_REPORT_TYPE_MASK) != HID_REPORT_TYPE_INPUT) { if ((setup->wValue & HID_GET_REPORT_TYPE_MASK) != HID_REPORT_TYPE_INPUT) {
LOG_ERR("Unsupported report type %d requested", (setup->wValue & HID_GET_REPORT_TYPE_MASK) << 8);
return -ENOTSUP; return -ENOTSUP;
} }
@ -63,6 +64,9 @@ static int zmk_usb_get_report(const struct device *dev,
report = zmk_hid_get_consumer_report(HID_REPORT_FULL); report = zmk_hid_get_consumer_report(HID_REPORT_FULL);
*len = sizeof(struct zmk_hid_consumer_report); *len = sizeof(struct zmk_hid_consumer_report);
break; break;
default:
LOG_ERR("Invalid report ID %d requested", setup->wValue & HID_GET_REPORT_ID_MASK);
return -EINVAL;
} }
*data = report; *data = report;