fix(core): Prevent pre-releasing explicit mods.

This commit is contained in:
Andrew Rae 2023-09-16 17:24:39 -04:00 committed by Pete Johanson
parent dffdb2365e
commit 2f05ad55ca

View file

@ -19,7 +19,8 @@ LOG_MODULE_DECLARE(zmk, CONFIG_ZMK_LOG_LEVEL);
static int hid_listener_keycode_pressed(const struct zmk_keycode_state_changed *ev) {
int err, explicit_mods_changed, implicit_mods_changed;
if (zmk_hid_is_pressed(ZMK_HID_USAGE(ev->usage_page, ev->keycode))) {
if (!is_mod(ev->usage_page, ev->keycode) &&
zmk_hid_is_pressed(ZMK_HID_USAGE(ev->usage_page, ev->keycode))) {
LOG_DBG("unregistering usage_page 0x%02X keycode 0x%02X since it was already pressed",
ev->usage_page, ev->keycode);
err = zmk_hid_release(ZMK_HID_USAGE(ev->usage_page, ev->keycode));