rename other_key_down_position in decide_tap_positionally_preferred)

This commit is contained in:
jding 2021-10-30 15:41:41 +00:00
parent bd8b98a7af
commit 26a6fbfefb

View file

@ -274,8 +274,8 @@ static void decide_hold_preferred(struct active_hold_tap *hold_tap, enum decisio
} }
} }
static bool does_pressed_key_trigger_hold(struct active_hold_tap *hold_tap, static bool does_other_key_down_position_trigger_hold(struct active_hold_tap *hold_tap,
int32_t other_key_down_position) { int32_t other_key_down_position) {
for (int i = 0; i < hold_tap->config->hold_trigger_key_positions_len; i++) { for (int i = 0; i < hold_tap->config->hold_trigger_key_positions_len; i++) {
if (hold_tap->config->hold_trigger_key_positions[i] == other_key_down_position) { if (hold_tap->config->hold_trigger_key_positions[i] == other_key_down_position) {
return true; return true;
@ -286,15 +286,16 @@ static bool does_pressed_key_trigger_hold(struct active_hold_tap *hold_tap,
static void decide_tap_positionally_preferred(struct active_hold_tap *hold_tap, static void decide_tap_positionally_preferred(struct active_hold_tap *hold_tap,
enum decision_moment event, enum decision_moment event,
int32_t pressed_key_position) { int32_t other_key_down_position) {
switch (event) { switch (event) {
case HT_KEY_UP: case HT_KEY_UP:
hold_tap->status = STATUS_TAP; hold_tap->status = STATUS_TAP;
return; return;
case HT_OTHER_KEY_DOWN: case HT_OTHER_KEY_DOWN:
hold_tap->status = does_pressed_key_trigger_hold(hold_tap, pressed_key_position) hold_tap->status =
? STATUS_HOLD_INTERRUPT does_other_key_down_position_trigger_hold(hold_tap, other_key_down_position)
: STATUS_TAP; ? STATUS_HOLD_INTERRUPT
: STATUS_TAP;
return; return;
case HT_TIMER_EVENT: case HT_TIMER_EVENT:
hold_tap->status = STATUS_TAP; hold_tap->status = STATUS_TAP;